Page 1 of 1

Regression: nested NZB files

Posted: July 26th, 2012, 9:45 am
by broady
Sometime between 0.5.6-0.7.2 the behaviour for nested NZB files changed. Often I will download a NZB file that contains many other NZB files, each adding a new download entry with the name of the nested NZB file. Unfortunately this fails when the parent NZB only contains one child NZB.

Steps:
Add NZB file "foo.nzb" contains just one nzb file: "bar.nzb"

Expected result:
New download entry created: "bar"

0.5.6 PASS
0.7.2 FAIL (bar.nzb is downloaded as "foo", and isn't renamed to "bar")

Steps:
Add NZB file "foo.nzb" containing "bar.nzb" and "baz.nzb"

Expected result:
Two new download entries created: "bar" and "baz"

0.5.6 PASS
0.7.2 PASS

Re: Regression: nested NZB files

Posted: July 26th, 2012, 10:09 am
by broady
Ah, found where it changed.
https://github.com/sabnzbd/sabnzbd/comm ... 8d4249fb0a

# For a single NZB, use the current job name
if len(files) != 1:
nzbname = None

sabnzbd/postproc.py

Re: Regression: nested NZB files

Posted: July 26th, 2012, 12:14 pm
by shypike
This was intentionally changed since I don't think the original behaviour is desirable.
(And quite often these nested NZB files have rather weird names).
When there's more than one NZB, the original name cannot be preserved.