Regression: nested NZB files

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
broady
Newbie
Newbie
Posts: 2
Joined: July 26th, 2012, 9:35 am

Regression: nested NZB files

Post by broady »

Sometime between 0.5.6-0.7.2 the behaviour for nested NZB files changed. Often I will download a NZB file that contains many other NZB files, each adding a new download entry with the name of the nested NZB file. Unfortunately this fails when the parent NZB only contains one child NZB.

Steps:
Add NZB file "foo.nzb" contains just one nzb file: "bar.nzb"

Expected result:
New download entry created: "bar"

0.5.6 PASS
0.7.2 FAIL (bar.nzb is downloaded as "foo", and isn't renamed to "bar")

Steps:
Add NZB file "foo.nzb" containing "bar.nzb" and "baz.nzb"

Expected result:
Two new download entries created: "bar" and "baz"

0.5.6 PASS
0.7.2 PASS
broady
Newbie
Newbie
Posts: 2
Joined: July 26th, 2012, 9:35 am

Re: Regression: nested NZB files

Post by broady »

Ah, found where it changed.
https://github.com/sabnzbd/sabnzbd/comm ... 8d4249fb0a

# For a single NZB, use the current job name
if len(files) != 1:
nzbname = None

sabnzbd/postproc.py
User avatar
shypike
Administrator
Administrator
Posts: 19773
Joined: January 18th, 2008, 12:49 pm

Re: Regression: nested NZB files

Post by shypike »

This was intentionally changed since I don't think the original behaviour is desirable.
(And quite often these nested NZB files have rather weird names).
When there's more than one NZB, the original name cannot be preserved.
Post Reply