Logging is wrong when Prequeue declines job
Posted: November 6th, 2011, 12:01 pm
On my system there seems to be a (tiny) issue with the logging of prequeue events. In case the prequeue script declines a download, the SABnzbd log says that it accepted the job. The job does get kicked out of the queue though (so the response is actually handled correctly, just logged wrongly).
can anyone confirm this?
As you can see, it says that the pre-Q accepts the job, and the millsecond later it starts removing the __ADMIN__ files.
Also, my proposal would be that jobs declined by Pre-Q somehow go into history anyway. Right now it's a bit of a blackbox (jobs just "disappear" magically and you have to keep in mind "ah right, that's my prequeue script). My porposal would be that any line past the 7th line of the output of the prequeue script is logged and viewable via history. The deluxe-version would be a "download anyway" link next to the history entry, similar to the "retry" link we have when a job failed repairing / extracting. The "download anyway" link would either skip the prequeue script or execute it but ignore the first line of the response (reject / accept). But no hard feelings if you have more important features to add.
can anyone confirm this?
As you can see, it says that the pre-Q accepts the job, and the millsecond later it starts removing the __ADMIN__ files.
Also, my proposal would be that jobs declined by Pre-Q somehow go into history anyway. Right now it's a bit of a blackbox (jobs just "disappear" magically and you have to keep in mind "ah right, that's my prequeue script). My porposal would be that any line past the 7th line of the output of the prequeue script is logged and viewable via history. The deluxe-version would be a "download anyway" link next to the history entry, similar to the "retry" link we have when a job failed repairing / extracting. The "download anyway" link would either skip the prequeue script or execute it but ignore the first line of the response (reject / accept). But no hard feelings if you have more important features to add.
... (adds all files to queue)
2011-11-06 17:45:59,128::INFO::[__init__:516] Backing up /mnt/md0/Videos/Downloads/incomplete/Supernatural - 6x01 - Exile On Main St/__ADMIN__/Supernatural - 6x01 - Exile On Main St.nzb.gz
2011-11-06 17:45:59,222::DEBUG::[tvsort:186] Found TV Show - Starting folder sort (Supernatural - 6x01 - Exile On Main St)
2011-11-06 17:45:59,403::INFO::[newsunpack:1404] Running pre-queue script ['/opt/sabnzbd/.sabnzbd/scripts/prequeue.php', 'Supernatural - 6x01 - Exile On Main St', '3', 'tvcat',
2011-11-06 17:46:00,076::INFO::[newsunpack:1424] Pre-Q accepts Supernatural - 6x01 - Exile On Main St
2011-11-06 17:46:00,078::INFO::[__init__:827] /mnt/md0/Videos/Downloads/incomplete/Supernatural - 6x01 - Exile On Main St/__ADMIN__/SABnzbd_nzf_Auzmkg removed
... (goes on for all files)