Page 1 of 1

'Save Changes' for server won't save unless settings are valid

Posted: October 24th, 2019, 7:02 pm
by OneCD
Hi Guys.

I've just noticed if I attempt to add a personal note to a server that is not yet fully configured, I get a 'failed' message as the "server address xxx:119" is not valid". This is correct - I often include a dummy server address while I'm testing SAB package installation and upgrading.

But, is it really necessary to validate settings before allowing them to be saved?

We have a separate button for 'Test Server', so the user can check the validity of their settings whenever they like. I don't think there's a need to restrict saving all server settings just because the server address isn't valid. The same dummy address was configured during the initial wizard setup and was accepted without error.

Thank you. :)

Re: 'Save Changes' for server won't save unless settings are valid

Posted: October 31st, 2019, 8:24 am
by safihre
We only check a very few fields to be there. If they aren't there, it might break the code in a later stage.
So rather than allowing bad settings, we just reject them.
I am surprised that it worked during wizard, the saving should go through the same code. Although now I am starting to doubt that :P

Re: 'Save Changes' for server won't save unless settings are valid

Posted: October 31st, 2019, 3:18 pm
by OneCD
No worries, thanks @safihre. :)