Page 1 of 1

TLS v1 = TLS v1.0?

Posted: May 20th, 2017, 1:12 pm
by HomerJay
Hello there,

first of all let me say I am really happy about the ability to check the current connection's encryption type used. Very useful feature!

However, there is one thing I don't understand: when it says TLS v1, does v1 equal 1.0, or does this include the .1 or .2? I know for a fact that my newsserver supports TLS v1.2, so why would it always use 1.0 when 1.2 is support? But maybe there's something to this I don't quite understand yet :)

Thanks!

Re: TLS v1 = TLS v1.0?

Posted: May 20th, 2017, 1:54 pm
by sander
It's tls 1.0

Which newsserver?
Which OS is Sabnzbd running on?

Re: TLS v1 = TLS v1.0?

Posted: May 20th, 2017, 2:18 pm
by HomerJay
Thanks so far!

It's running on macOS 10.12.5

Is this possible due to an old openssl library on my Mac that doesn't support tls 1.2?

Re: TLS v1 = TLS v1.0?

Posted: May 20th, 2017, 2:56 pm
by safihre
On the first page of the Config it should show you the supported versions of your OpenSSL version!

Re: TLS v1 = TLS v1.0?

Posted: May 20th, 2017, 3:19 pm
by HomerJay
You know what? I never noticed that line on that page :D

Ok, so there it shows OpenSSL 0.9.8zh 14 Jan 2016 [TLS v1, SSL v3, SSL v2] BUT I just updatet my OpenSSL library to the most current version, but sabnzbd takes no notice of that, so it seems.

Re: TLS v1 = TLS v1.0?

Posted: May 21st, 2017, 3:21 am
by safihre
No indeed it doesn't. It's because python in the end is still C code that calls the specific OpenSSL functions to handle the connections. Because these functions change between OpenSSL versions, python releases are linked to a specific version of OpenSSL.
This is specific to the windows and Mac versions of python.
I tried building it with the latest OpenSSL, but then the connections fail.

Re: TLS v1 = TLS v1.0?

Posted: May 21st, 2017, 3:37 am
by HomerJay
I made a little mistake there: I didn't install the latest openssl, just the latest that comes with homebrew, which is 1.0.2k. The latest would be 1.1.0 something.

So how long am I stuck whith the 0.9.8 library?

Re: TLS v1 = TLS v1.0?

Posted: May 21st, 2017, 3:48 am
by safihre
Until Python updates it.
But, don't just look at the version number. This is all because Apple has some special ideas about OpenSSL and thus they keep it at 0.9.8.
Maybe for Python 2.7.14 we can change the OpenSSL version again.

Re: TLS v1 = TLS v1.0?

Posted: May 23rd, 2017, 10:04 am
by safihre
So I experimented to use the homebrew python and openssl, and it worked.
Now it has TLSv1 to TLSv1.2.

Could you test this?
https://github.com/sabnzbd/sabbuild/rel ... ebrew-test

Re: TLS v1 = TLS v1.0?

Posted: May 28th, 2017, 5:45 am
by HomerJay
Sorry for the late reply. I haven't had a chance to test this, but I will very soon! Thanks for your effort!! I'll report back.

Look's like I waited too long: link isn't working anymore.

Re: TLS v1 = TLS v1.0?

Posted: May 28th, 2017, 6:24 am
by HomerJay
Ok, what I could test though was the 2.1.0Beta1, sadly with the same result. Am I supposed to uninstall the old version first?

Anything else I need to change, although it says "bundled ssl" in the ReadMe?

Re: TLS v1 = TLS v1.0?

Posted: May 28th, 2017, 11:32 am
by safihre
It turns out that the release I created with newer OpenSSL did not function on most systems and caused sabnzbd to not work at all for them. So I reverted the change back in 2.1.0Beta1.

Re: TLS v1 = TLS v1.0?

Posted: May 29th, 2017, 12:18 pm
by HomerJay
The change was still listed in the ReadMe when I downloaded it, therefore the confusion.

If you like me to test something on a Mac, just let me know!