Page 1 of 1

rss config page painfully slow

Posted: September 10th, 2016, 8:49 am
by diamaunt
Version: 1.03
OS: Solaris
install: Python source.
skin: plush gold
router firewall
not ipv6
depressingly reproducable.

My problem is that bringing up any rss feed page takes 10-12 seconds, then every single change takes 11-12 seconds, it's like it's reprocessing the rss feed every time, whether I'm adding, deleting, changing anything on the page. it's painful!

if indeed it's doing that... WHY? why can't it just wait until changes are done, or the 'read feed' button is clicked?
I'm talking about one rss feed, with 30 entries in the rss config page. it takes 1.08 seconds to read the rss feed with curl, but sab takes up all of one core (4 core server) for 11-12 seconds before the screen comes back for something as simple as editing a specific filter entry.

Re: rss config page painfully slow

Posted: September 11th, 2016, 4:34 am
by shypike
The RSS filter page can indeed be painfully slow.
If you have lots of filters involving season/episode expressions
or your own regular expressions, combined with a feed with many entries,
evaluation will become slow.
This is because a very large amount of regular expressions (multiple in the case of season/episode)
need to be applied to all of the entries.
We know this needs optmalisation, but haven't succeeded in doing so.
Each time you change a filter all filters are re-applied, because that's the only way
you can get a proper result.
One optimization could be to do re-evaluation only on-demand.

We will tackle this in the next major release (but not 1.1.0, which is just out).

Re: rss config page painfully slow

Posted: September 11th, 2016, 1:36 pm
by diamaunt
I think (not having looked at the code, or franky, knowing more about python other than "I think that's python") that the best possible optimization would be to only do the re-evaluation when exiting the rss screen, (or when clicking the button to pull the feed and see what matches?) I can't see any reason (keeping in mind, my ignorance) to do it for every change.

I upgraded to 1.1.0 yesterday after seeing the update notice... keep up the good work!

Re: rss config page painfully slow

Posted: September 11th, 2016, 1:53 pm
by shypike
Well, many people want direct feedback on their filter settings, just to see if it works as they want it.
But for large setups an "evaluate" button would be better than automatic.

Re: rss config page painfully slow

Posted: September 11th, 2016, 3:24 pm
by diamaunt
shypike wrote:Well, many people want direct feedback on their filter settings, just to see if it works as they want it.
But for large setups an "evaluate" button would be better than automatic.
please please please please please! :D

sometimes I have several changes, and what should take a small number of seconds often takes many minutes, and so I sometimes put off making changes... :(