Page 1 of 1

Test-email tests saved values, not currently entered values.

Posted: April 16th, 2014, 2:44 am
by trezor
Technically speaking, this is really a minor bug, but if you don't know about this/is able to guess it, email configuration can be a real confusing thing.

To reproduce the issue do the following:
  • Setup email notification against gmail or whatever in sabnzbd.
  • Have a heartbleed bug, change your email account's password.
  • Go to sabnzbd's notification configuration.
  • Enter your new password under "Email account settings". DO NOT click save.
  • Click "Test".
Observe that: Sending test-email will fail until you click "Save".

It's not obvious that you need to save before the config can be tested. Personally I expect "Test" allows me to verify that something works before saving.

Any chance getting this fixed? :)

Re: Test-email tests saved values, not currently entered val

Posted: April 16th, 2014, 4:09 am
by shypike
Maybe, it goes into the todo list.

Re: Test-email tests saved values, not currently entered val

Posted: April 16th, 2014, 5:22 am
by trezor
Thanks. Sounds good.

Not any deal killer by any means, but just thought I'd bring it up since I think that would improve an otherwise excellent product :)

Seeing as I now found the github issue list, any point resubmitting there?

https://github.com/sabnzbd/sabnzbd/issues

And if I decide I have time to look into this myself, are there any strict requirements for pull-requests to be accepted? Any contributer guidelines I should be aware of or look into?

Re: Test-email tests saved values, not currently entered val

Posted: April 16th, 2014, 7:46 am
by shypike
trezor wrote: And if I decide I have time to look into this myself, are there any strict requirements for pull-requests to be accepted? Any contributer guidelines I should be aware of or look into?
It would be great if you did this.
Please base your work on the 0.7.x branch.

Re: Test-email tests saved values, not currently entered val

Posted: April 22nd, 2014, 12:32 pm
by trezor
Done and done :)