[slvd]Postproc fails on joinables with certain parchive sets

[Usr12]

Hi,

There seems to be an issue when handling certain parchive sets, when the files need to be joined/concatenated in the verification process. I.e the parchive lists 'file.iso', but we have 'file.iso.001', 'file.iso.002' etc.

Sab handles this on older sets - consider this - but newer sets will fail.

Log of failed set:

Code: Select all

[postproc:280] Starting PostProcessing on file.iso => Repair:True, Unpack:True, Delete:True, Script:None, Cat:*
2012-09-16 13:54:36,671::INFO::[postproc:546] Par2 check starting on file.iso
2012-09-16 13:54:36,672::INFO::[postproc:561] Running repair on set file.iso
2012-09-16 13:54:36,673::INFO::[newsunpack:1305] Cannot Quick-check missing file file.iso!
2012-09-16 13:54:36,673::INFO::[newsunpack:789] Scanning "/folder/file.iso.vol03+04.par2"
2012-09-16 13:54:36,674::DEBUG::[newsunpack:1270] build_filelists(): joinables: ['/folder/file.iso.001', '/folder/file.iso.002', '/folder/file.iso.003', '/folder/file.iso.004', '/folder/file.iso.005', '/folder/file.iso.006', '/folder/file.iso.007', '/folder/file.iso.008']
2012-09-16 13:54:36,674::DEBUG::[newsunpack:1271] build_filelists(): zips: []
2012-09-16 13:54:36,674::DEBUG::[newsunpack:1272] build_filelists(): rars: ['/folder/file.iso.001', '/folder/file.iso.002', '/folder/file.iso.003', '/folder/file.iso.004', '/folder/file.iso.005', '/folder/file.iso.006', '/folder/file.iso.007', '/folder/file.iso.008']
2012-09-16 13:54:36,674::DEBUG::[newsunpack:1273] build_filelists(): ts: []
2012-09-16 13:54:36,674::DEBUG::[newsunpack:894] Par2-classic = True
2012-09-16 13:54:36,674::DEBUG::[newsunpack:912] Starting par2: ['/usr/bin/par2', 'r', '/folder/file.iso.vol03+04.par2', '/folder/file.iso.001', '/folder/file.iso.002', '/folder/file.iso.003', '/folder/file.iso.004', '/folder/file.iso.005', '/folder/file.iso.006', '/folder/file.iso.007', '/folder/file.iso.008']
2012-09-16 13:54:39,031::INFO::[newsunpack:807] Par verify failed on /folder/file.iso.vol03+04.par2!
2012-09-16 13:54:39,030::INFO::[newsunpack:971] Verified in 2 seconds, repair is required
2012-09-16 13:54:39,031::INFO::[postproc:574] Par2 check finished on file.iso
2012-09-16 13:54:39,603::INFO::[postproc:519] Cleaning up file.iso (keep_basic=True)

This bug seems to be reproducible with any newer posts (look for '*.iso.001', '*.mkv.001', '*.avi.001" etc).
When running the command manually (par2 r file.iso.par2 file.iso.0*), I get the following:

Code: Select all

Repair is possible.


Could not allocate buffer memory.

This I am also able to reproduce. However, it works perfectly on older sets.
Quickpar handles these parchives with no issues.

Wikipedia also mentions this bug.

Looks like the code needs some additions. Currently, sab only merges files which have passed verification, but par2 seems unable to merge the files on its own.

[shypike]

Which OS are you using?
The issue may very depend on the specific par2 that you are using.
I checked the following with your example NZB.
OSX (10.8 ): OK
Ubuntu 12.04 (32bit): OK
Windows 7 (64bit) : OK

[Usr12]

I'm on Linux (Arch 3.5.3)

Actually this is total fail on my part -- I was using an acient tbb-version of par2cmdline.. Reverted back to the newest git-version (still old code though). Doesn't seem to be much speed difference either.

Anyway, things are back to normal - sorry for the trouble