Category/Priority not responding as intended

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
SkyFrace
Newbie
Newbie
Posts: 6
Joined: February 12th, 2013, 1:30 am

Category/Priority not responding as intended

Post by SkyFrace »

I have discovered a bug which I cannot solve.

I am currently using Newznab (Send to My SABnzbd) function
I have categories set up
When I set the priority in the category (e.g. High), the priority remains `Normal` however I set the priority.
When the file has downloaded, the file is sorted into the correct folder.

I hope this feedback helps make this even better than the awesome software that it is.

Regards and thank you

EDIT
Using SABnzbd on a Synology Busybox v0.7.11-6
User avatar
shypike
Administrator
Administrator
Posts: 19773
Joined: January 18th, 2008, 12:49 pm

Re: Category/Priority not responding as intended

Post by shypike »

The priority of the category is only used when there's no explicit priority in the API call sending the NZB.
Apparently newznab sends along a priority.
SkyFrace
Newbie
Newbie
Posts: 6
Joined: February 12th, 2013, 1:30 am

Re: Category/Priority not responding as intended

Post by SkyFrace »

Thank you

If this isn't a bug, then maybe an override function could be considered.

Lets say I set up category's `Books*` then a priority because I need these first... always.
If the Priority is set in Categorys, then this overrides the Priority sent along with the instructions received with the function associated with `Send to My SABnzbz`

I can see the point of having a set priority in the first instance, but I think the function is underexploited.

Maybe the team could consider making the set Priority in Category's override the first instruction.
This is unless there is some other logical reason why this software works this way.

I thank you all for making this software work as fantastic .
Regards
User avatar
jcfp
Release Testers
Release Testers
Posts: 1032
Joined: February 7th, 2008, 12:45 pm

Re: Category/Priority not responding as intended

Post by jcfp »

SkyFrace wrote:If this isn't a bug, then maybe an override function could be considered.
What you want is to override the override. The obvious answer to that is: don't override anything in the first place. For sab it makes sense to allow specific jobs to have different settings from their category's defaults when ordered so, no different from how the settings associated with a specific category overrule those of the default category. Your real problem is with the third party sending the api call, apparently enforcing a priority on every job it adds.

The obvious place to fix is in that third party application or website, for example by not having it send a priority or making its behaviour configurable. Failing that, as a workaround you could use a pre-queue script to enforce your desired priority for the relevant category.
SkyFrace
Newbie
Newbie
Posts: 6
Joined: February 12th, 2013, 1:30 am

Re: Category/Priority not responding as intended

Post by SkyFrace »

Thank you for your suggestion.

Override the override call which overrides the default Priority.
I see what you are saying, fix the setting for the Category where the call was made.

Seriously, I will look at the script options, I was playing around with the scripting yesterday, and it's not so complicated.

If I figure a workable solution, I will post the code here...

Regards
SkyFrace
Newbie
Newbie
Posts: 6
Joined: February 12th, 2013, 1:30 am

Re: Category/Priority not responding as intended

Post by SkyFrace »

I have my script, I am trying to test it.

I activated Status->+Debug, I do not see the script name (bk2top_prio.sh) in the log

I am running a Synology NAS, it is a Busbox and runs ash natively
I am guessing that the script, chmod 777 in (/usr/local/sabnzbd/var/scripts) is not running

Has anyone any tips on getting the script to run so I can test...

Regards and Thank you
User avatar
jcfp
Release Testers
Release Testers
Posts: 1032
Joined: February 7th, 2008, 12:45 pm

Re: Category/Priority not responding as intended

Post by jcfp »

You'll still have to tell sab to use that script as its pre-queue script (config -> switches -> "Pre-queue user script"), just putting it in the script dir won't do that.
SkyFrace
Newbie
Newbie
Posts: 6
Joined: February 12th, 2013, 1:30 am

Re: Category/Priority not responding as intended

Post by SkyFrace »

Thank you

I would not have come onto that on my own.

Now the script is working, triggering priority on low file size first

Code: Select all

#!/bin/sh

#Change priority to High if file size is small, equal or same as 20MB
if [ "$6" -le "20" ]
   then
   priority="1"
fi

### return things to sab (changed or unchanged)
echo 1             # 0=Refuse, 1=Accept
echo $nzb          # Name of the NZB (no path, no ".nzb")
echo $2            # PP (0, 1, 2 or 3)
echo $3            # Category
echo $4            # Script (basename)
echo $priority     # Priority (-100 -2, -1, 0 or 1, meaning Default, Paused, Low, Normal, High )
echo $6            # Group to be used (in case your provider doesn't carry all groups and there are multiple groups in the N$
Thank you for your help, everything is working now

1. Name your script and put it in the scripts folder (chmod to 777)
2.Tell SABnzbz to use script pre-queue script (config -> switches -> "Pre-queue user script") thanks jcfp
3. Set up Category and script to use
Post Reply