Series Sort %fn incorrectly substituting full path

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
zmcddna
Newbie
Newbie
Posts: 4
Joined: December 19th, 2012, 3:21 am

Series Sort %fn incorrectly substituting full path

Post by zmcddna »

Using the following Series Sort:

%sn\%0s%0e-%fn.%ext (produces result like "Show Name\0105-Original Filename.avi")

Occasionally the rename fails because sabnzbd uses a full path for %fn instead of a bare filename. So it becomes "Show Name\0105-C:\Full\Path\Original Filename.avi" and fails.

Here's an example, version 0.7.6:

Code: Select all

2012-12-18 08:51:40,313::INFO::[postproc:272] Starting PostProcessing on Test.Show.One.S03E31.480p.HDTV.x264-mSD => Repair:True, Unpack:True, Delete:True, Script:None, Cat:tv
2012-12-18 08:51:40,315::INFO::[postproc:538] Par2 check starting on Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,319::INFO::[__init__:852] F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\__ADMIN__\__verified__ missing
2012-12-18 08:51:40,319::INFO::[postproc:558] Running repair on set Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,319::DEBUG::[newsunpack:1345] Quick-check of file Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv OK
2012-12-18 08:51:40,319::DEBUG::[newsunpack:1345] Quick-check of file Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo OK
2012-12-18 08:51:40,319::INFO::[newsunpack:793] Quick-check for Test.Show.One.S03E31.480p.HDTV.x264-mSD is OK, skipping repair
2012-12-18 08:51:40,319::INFO::[newsunpack:855] Deleting F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.par2
2012-12-18 08:51:40,319::INFO::[newsunpack:883] Deleting F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.vol000+01.par2
2012-12-18 08:51:40,319::INFO::[newsunpack:883] Deleting F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.vol001+02.par2
2012-12-18 08:51:40,319::DEBUG::[__init__:822] Saving data for __verified__ in F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\__ADMIN__
2012-12-18 08:51:40,321::INFO::[postproc:582] Par2 check finished on Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,322::DEBUG::[tvsort:215] Found TV Show - Starting folder sort (Test.Show.One.S03E31.480p.HDTV.x264-mSD)
2012-12-18 08:51:40,359::INFO::[misc:781] Creating directories: F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,361::INFO::[postproc:334] Running unpack_magic on Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,361::DEBUG::[newsunpack:1318] build_filelists(): joinables: []
2012-12-18 08:51:40,361::DEBUG::[newsunpack:1319] build_filelists(): zips: []
2012-12-18 08:51:40,361::DEBUG::[newsunpack:1320] build_filelists(): rars: []
2012-12-18 08:51:40,361::DEBUG::[newsunpack:1321] build_filelists(): ts: []
2012-12-18 08:51:40,361::INFO::[postproc:336] unpack_magic finished on Test.Show.One.S03E31.480p.HDTV.x264-mSD
2012-12-18 08:51:40,361::DEBUG::[misc:805] Moving. Old path:F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv new path:F:\U\tv\Test Show One\_UNPACK_Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv overwrite?:0
2012-12-18 08:51:40,361::DEBUG::[misc:805] Moving. Old path:F:\U\_Sab\Temp\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo new path:F:\U\tv\Test Show One\_UNPACK_Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo overwrite?:0
2012-12-18 08:51:40,364::DEBUG::[tvsort:400] Renaming Series
2012-12-18 08:51:40,364::DEBUG::[tvsort:438] Rename: F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv to F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\0331-F:\U\tv\Test Show One\_UNPACK_Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv
2012-12-18 08:51:40,364::ERROR::[tvsort:441] Failed to rename: F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD to F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\0331-F:\U\tv\Test Show One\_UNPACK_Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv
2012-12-18 08:51:40,364::INFO::[tvsort:442] Traceback: 
Traceback (most recent call last):
  File "sabnzbd\tvsort.pyo", line 439, in rename
  File "sabnzbd\misc.pyo", line 1241, in renamer
WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect
2012-12-18 08:51:40,365::DEBUG::[tvsort:1102] Give files in set "0331-%fn" matching names.
2012-12-18 08:51:40,365::DEBUG::[tvsort:1121] Rename: F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo to F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\0331-Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo
2012-12-18 08:51:40,365::DEBUG::[misc:805] Moving. Old path:F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\0331-Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo new path:F:\U\tv\Test Show One\0331-Test.Show.One.S03E31.480p.HDTV.x264-mSD.nfo overwrite?:0
2012-12-18 08:51:40,365::DEBUG::[misc:805] Moving. Old path:F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv new path:F:\U\tv\Test Show One\Test.Show.One.S03E31.480p.HDTV.x264-mSD.mkv overwrite?:0
2012-12-18 08:51:40,602::INFO::[postproc:511] Cleaning up Test.Show.One.S03E31.480p.HDTV.x264-mSD (keep_basic=False)
Another example, running version 0.7.7 from source (added a few of my own debugging statments in tvsort):

Code: Select all

2012-12-18 22:11:10,733::DEBUG::[newsunpack:1356] Quick-check of file Test.Show.Two.S02E12.HDTV.x264-LOL.part12.rar OK
2012-12-18 22:11:10,734::DEBUG::[newsunpack:1356] Quick-check of file Test.Show.Two.S02E12.HDTV.x264-LOL.part11.rar OK
2012-12-18 22:11:10,736::DEBUG::[newsunpack:1356] Quick-check of file Test.Show.Two.S02E12.HDTV.x264-LOL.part10.rar OK
2012-12-18 22:11:10,737::INFO::[newsunpack:793] Quick-check for Test.Show.Two.S02E12.HDTV.x264-LOL is OK, skipping repair
2012-12-18 22:11:10,740::INFO::[newsunpack:855] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.par2
2012-12-18 22:11:10,743::DEBUG::[__init__:822] Saving data for __verified__ in F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\__ADMIN__
2012-12-18 22:11:10,746::INFO::[postproc:582] Par2 check finished on Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,749::DEBUG::[tvsort:215] Found TV Show - Starting folder sort (Test.Show.Two.S02E12.HDTV.x264-LOL)
2012-12-18 22:11:10,786::INFO::[misc:781] Creating directories: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,790::INFO::[postproc:334] Running unpack_magic on Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,792::DEBUG::[newsunpack:1329] build_filelists(): joinables: []
2012-12-18 22:11:10,793::DEBUG::[newsunpack:1330] build_filelists(): zips: []
2012-12-18 22:11:10,795::DEBUG::[newsunpack:1331] build_filelists(): rars: ['F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part02.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part03.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part04.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part05.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part06.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part07.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part08.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part09.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part10.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part11.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part12.rar']
2012-12-18 22:11:10,812::DEBUG::[newsunpack:1332] build_filelists(): ts: []
2012-12-18 22:11:10,813::INFO::[newsunpack:207] Unrar starting on F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,816::DEBUG::[newsunpack:405] Rar_sets: {'Test.Show.Two.S02E12.HDTV.x264-LOL': ['F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part02.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part03.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part04.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part05.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part06.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part07.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part08.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part09.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part10.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part11.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part12.rar']}
2012-12-18 22:11:10,834::INFO::[newsunpack:419] Extracting rarfile F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar (belonging to Test.Show.Two.S02E12.HDTV.x264-LOL) to F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,838::DEBUG::[newsunpack:516] rar_extract(): Extractionpath: F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:10,842::DEBUG::[newsunpack:561] Running unrar ['C:\\Util\\SABnzbd-0.7.7\\win\\unrar\\x64\\UnRAR.exe', 'x', '-idp', '-o-', '-or', '-ai', '-p-', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar', 'F:\\U\\tv\\Test Show Two\\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL/']
2012-12-18 22:11:11,727::DEBUG::[newsunpack:666] Checking existence of F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,730::DEBUG::[newsunpack:666] Checking existence of F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Top Usenet Provider - CHEAP - FULL SPEED.url
2012-12-18 22:11:11,733::DEBUG::[newsunpack:666] Checking existence of F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\TOWN - NZB FORUM - KLICK IT.url
2012-12-18 22:11:11,736::INFO::[newsunpack:687] Unpacked 3 files/folders in 0 seconds
2012-12-18 22:11:11,736::DEBUG::[newsunpack:436] rar_unpack(): Rars: ['F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part02.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part03.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part04.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part05.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part06.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part07.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part08.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part09.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part10.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part11.rar', 'F:\\U\\_Sab\\Temp\\Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.S02E12.HDTV.x264-LOL.part12.rar']
2012-12-18 22:11:11,753::DEBUG::[newsunpack:437] rar_unpack(): Newfiles: ['F:\\U\\tv\\Test Show Two\\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\\Test.Show.Two.212.hdtv-lol.mp4', 'F:\\U\\tv\\Test Show Two\\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\\Top Usenet Provider - CHEAP - FULL SPEED.url', 'F:\\U\\tv\\Test Show Two\\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\\TOWN - NZB FORUM - KLICK IT.url']
2012-12-18 22:11:11,759::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part01.rar
2012-12-18 22:11:11,763::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part02.rar
2012-12-18 22:11:11,766::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part03.rar
2012-12-18 22:11:11,769::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part04.rar
2012-12-18 22:11:11,773::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part05.rar
2012-12-18 22:11:11,776::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part06.rar
2012-12-18 22:11:11,779::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part07.rar
2012-12-18 22:11:11,782::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part08.rar
2012-12-18 22:11:11,786::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part09.rar
2012-12-18 22:11:11,789::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part10.rar
2012-12-18 22:11:11,792::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part11.rar
2012-12-18 22:11:11,796::INFO::[newsunpack:443] Deleting F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.S02E12.HDTV.x264-LOL.part12.rar
2012-12-18 22:11:11,799::INFO::[newsunpack:211] Unrar finished on F:\U\_Sab\Temp\Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:11,802::DEBUG::[newsunpack:1329] build_filelists(): joinables: []
2012-12-18 22:11:11,803::DEBUG::[newsunpack:1330] build_filelists(): zips: []
2012-12-18 22:11:11,805::DEBUG::[newsunpack:1331] build_filelists(): rars: []
2012-12-18 22:11:11,805::DEBUG::[newsunpack:1332] build_filelists(): ts: []
2012-12-18 22:11:11,806::INFO::[postproc:336] unpack_magic finished on Test.Show.Two.S02E12.HDTV.x264-LOL
2012-12-18 22:11:11,809::DEBUG::[tvsort:400] Renaming Series
2012-12-18 22:11:11,812::DEBUG::[tvsort:430] >>> self.fname: F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol
2012-12-18 22:11:11,813::DEBUG::[tvsort:431] >>> self.ext: .mp4
2012-12-18 22:11:11,815::DEBUG::[tvsort:433] >>> newname: 0212-%fn.mp4
2012-12-18 22:11:11,815::DEBUG::[tvsort:436] >>> newname: 0212-F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,818::DEBUG::[tvsort:438] >>> newpath: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,822::DEBUG::[tvsort:441] >>> newpath: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,825::DEBUG::[tvsort:444] Rename: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4 to F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,828::ERROR::[tvsort:447] Failed to rename: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL to F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-F:\U\tv\Test Show Two\_UNPACK_Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4
2012-12-18 22:11:11,831::INFO::[tvsort:448] Traceback: 
Traceback (most recent call last):
  File "C:\Util\SABnzbd-0.7.7\sabnzbd\tvsort.py", line 445, in rename
    renamer(filepath, newpath)
  File "C:\Util\SABnzbd-0.7.7\sabnzbd\misc.py", line 1241, in renamer
    raise WindowsError(err)
WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect
2012-12-18 22:11:11,836::DEBUG::[tvsort:1111] Give files in set "0212-%fn" matching names.
2012-12-18 22:11:11,838::DEBUG::[tvsort:1132] Rename: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\Top Usenet Provider - CHEAP - FULL SPEED.url to F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-Top Usenet Provider - CHEAP - FULL SPEED.url
2012-12-18 22:11:11,842::DEBUG::[tvsort:1132] Rename: F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\TOWN - NZB FORUM - KLICK IT.url to F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-TOWN - NZB FORUM - KLICK IT.url
2012-12-18 22:11:11,845::DEBUG::[misc:805] Moving. Old path:F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-Top Usenet Provider - CHEAP - FULL SPEED.url new path:F:\U\tv\Test Show Two\0212-Top Usenet Provider - CHEAP - FULL SPEED.url overwrite?:0
2012-12-18 22:11:11,849::DEBUG::[misc:805] Moving. Old path:F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\0212-TOWN - NZB FORUM - KLICK IT.url new path:F:\U\tv\Test Show Two\0212-TOWN - NZB FORUM - KLICK IT.url overwrite?:0
2012-12-18 22:11:11,852::DEBUG::[misc:805] Moving. Old path:F:\U\tv\Test Show Two\Test.Show.Two.S02E12.HDTV.x264-LOL\Test.Show.Two.212.hdtv-lol.mp4 new path:F:\U\tv\Test Show Two\Test.Show.Two.212.hdtv-lol.mp4 overwrite?:0
2012-12-18 22:11:11,996::INFO::[postproc:511] Cleaning up Test.Show.Two.S02E12.HDTV.x264-LOL (keep_basic=False)
The issue seems to be the "newfiles" list coming from newsunpack.py and/or postproc.py and passed into tvsort.py->rename() sometimes contains full pathnames and sometimes just bare filenames. Possibly depending on what kind of archive was unpacked?

I fixed it for myself by stripping the full path in the rename function, but I don't know if there's a deeper issue with the inconsistent inputs or whatever. Let me know if you would like more info.
User avatar
shypike
Administrator
Administrator
Posts: 19773
Joined: January 18th, 2008, 12:49 pm

Re: Series Sort %fn incorrectly substituting full path

Post by shypike »

Good find.
Under some circumstances, the name used as the basis for %fn is a full path instead if just the base name.
It has to do with the way unpacking returns its "unpacked files" list.
The code naively assumes that only base names are passed.
I will fix this for the next release.
Unfortunately there is no work around for the binary distribution.
When you're running 0.7.7 from source, you can substitute tvsort.py with this one:
https://github.com/sabnzbd/sabnzbd/blob ... /tvsort.py
zmcddna
Newbie
Newbie
Posts: 4
Joined: December 19th, 2012, 3:21 am

Re: Series Sort %fn incorrectly substituting full path

Post by zmcddna »

Just hit a different error in Date Sorting, looks like maybe a line was missed in a Nov 26 update.

Code: Select all

2012-12-19 15:33:07,872::INFO::[postproc:478] Traceback: 
Traceback (most recent call last):
  File "C:\Util\SABnzbd-0.7.7\sabnzbd\postproc.py", line 407, in process_job
    file_sorter.rename(newfiles, workdir_complete)
  File "C:\Util\SABnzbd-0.7.7\sabnzbd\tvsort.py", line 136, in rename
    self.sorter.rename(newfiles, workdir_complete)
  File "C:\Util\SABnzbd-0.7.7\sabnzbd\tvsort.py", line 902, in rename
    rename_similar(current_path, ext, self.filename_set)
TypeError: rename_similar() takes exactly 4 arguments (3 given)
User avatar
shypike
Administrator
Administrator
Posts: 19773
Joined: January 18th, 2008, 12:49 pm

Re: Series Sort %fn incorrectly substituting full path

Post by shypike »

Thanks again.
I'll look into it.

Fixed now. The call needs an extra () parameter.
Post Reply