0.6.2: double quotes not removed from directory name.

[yokel]

Fresh install on CentOs 5.6; double quotes remain in directory names. This is resulting in very strange names when viewed over a Samba share.
f.i. directory aa"bb is seen as AOQT10~3.

Both switches 'Replace dots in Foldername'  and ' Replace Illegal Characters in Folder Names' are enabled.

[shypike]

A double quote is a perfectly legal characters in Unix filenames.
For some reason Samba doesn't support it.
SABnzbd doesn't know that you are using Samba, because it only
deals with the native file system.
One work-around would be to use a pre-queue script in which
you remove the double quotes from the names.

Assuming you run from 0.6.2 sources, you can patch the code.
Module sabnzbd/misc.py
Replace lines 193/194

Code: Select all

    CH_ILLEGAL = r'/'
    CH_LEGAL   = r'+'

with these

Code: Select all

    CH_ILLEGAL = r'/"'
    CH_LEGAL   = r'+\''

Maybe it's a good idea to change this in the next release.
However, the problem remains that Samba probably uses
the rules for Windows, while SABnzbd uses the native Unix rules.

[yokel]

Thanks for the prompt reply.
Gonna try this as soon as I'm home.

[yokel]

Worked like a charm. (the code change that is)

Thanks again!

[Pearf]

Hi,
this solution doesn't work for me. I'm on 0.5.4. Any suggestions?

Thanks

[shypike]

Upgrade?