Duplicate detection not working properly in 4.5.2+

[jcfp]

No hard feelings. As for guessit, if this scheme is indeed very common for anime (which I'm completely unfamiliar with myself), you could open an issue there and nicely ask them to add support for it.

[Hemloc]

I see someone already mentioned this problem 4 years ago, and they only catered for it (https://github.com/guessit-io/guessit/pull/778) in something called Kyoo last year. So it seems they do know about it, but the version used by sabnzbd does not. Perhaps that version would be more suitable for sabnzbd as it caters for TV, movies and anime? Just a thought

[safihre]

It seems nobody is maintaining guessit regularly..
Unfortunately not many options for us out there to use as detection library.
Or we have to vendor it, but not looking forward to that.

Some patches I can hack into it on runtime, but not this one unfortunately.

[sander]

hacking time:

The good:

Code: Select all

>>> guessit.guessit("[SubsPlease] Blablabla S2E10 (1080p) [something]")
MatchesDict([('title', 'Blablabla'), ('season', 2), ('episode', 10), ('screen_size', '1080p'), ('release_group', 'something'), ('type', 'episode')])
>>> guessit.guessit("[SubsPlease] Blablabla S2-E10 (1080p) [something]")
MatchesDict([('title', 'Blablabla'), ('season', 2), ('episode', 10), ('screen_size', '1080p'), ('release_group', 'something'), ('type', 'episode')])
>>> guessit.guessit("[SubsPlease] Blablabla S2 E10 (1080p) [something]")
MatchesDict([('title', 'Blablabla'), ('season', 2), ('episode', 10), ('screen_size', '1080p'), ('release_group', 'something'), ('type', 'episode')])

So: ('episode', 10) in all cases. Good.

The bad:

Code: Select all

>>> guessit.guessit("[SubsPlease] Blablabla S2 - 10 (1080p) [something]")
MatchesDict([('title', 'Blablabla'), ('season', 2), ('episode_title', '10'), ('screen_size', '1080p'), ('release_group', 'something'), ('type', 'episode')])
>>> guessit.guessit("[SubsPlease] Blablabla S2_-_10 (1080p) [something]")
MatchesDict([('title', 'Blablabla'), ('season', 2), ('episode_title', '10'), ('screen_size', '1080p'), ('release_group', 'something'), ('type', 'episode')])

No episode, but ('episode_title', '10'). The rest is the same.

If guessit developers do not solve it, we might consider this:
if SABnzbd sees season a number, and no episode from guessit, and episode_title is a number ... use the episode_title as episode. As in switch values of episode and episode_title.

I checked my sabnzbd.log, and
1) there was a episode_title for the Kakkou downloads, and always the number
2) there was never a episode_title for other downloads.

So seems safe to do this.

So somewhere in https://github.com/sabnzbd/sabnzbd/blob ... #L656-L686 ... ah, I see SAB already does some fixing for other guessit results?

[sander]

Easy to check for pure number resp empty string:

code:

Code: Select all

test_strings = ['12345', '123a45', '1.23', '-123', '', '0', 'blabla 12']
for s in test_strings:
  is_digit = s.isdigit()
  is_empty = s == ''
  print(f"String: '{s}', contains only digits: {is_digit}, is empty: {is_empty}")

result:

Code: Select all

String: '12345', contains only digits: True, is empty: False
String: '123a45', contains only digits: False, is empty: False
String: '1.23', contains only digits: False, is empty: False
String: '-123', contains only digits: False, is empty: False
String: '', contains only digits: False, is empty: True
String: '0', contains only digits: True, is empty: False
String: 'blabla 12', contains only digits: False, is empty: False

[jcfp]

Why not... https://github.com/sabnzbd/sabnzbd/pull/3146

[sander]

Beautiful!

Or even: schitterend!

[Hemloc]

From what I can gather from the pull request I mentioned from GuessIt, they say pretty much exactly what you are describing, i.e. 'Promote "episode_title" to "episode" when the title is in fact the episode number'. So if what you are suggesting in sabnzbd, matches pretty much what guessit did for kyoo, then yes, it does sound awesome

[safihre]

Merged. Will be in the next release!

[Hemloc]

Thanks very much everyone