[V1.0.0. Final Win10x64] Download Fails Unpacking, Completed

[mastyman]

[V1.0.0. Final Win10x64]

this is probably by design and not a bug at all, but im curious, if a download fails to unpack due to missing files, would it not be better if the status was 'failed' instead of 'completed' in sab

my <selfish> reasoning why it would be better if it was failed, since sonarr sees it with status completed not failed, it doesnt blacklist/retry another download, have to manually intervene.

http://imgur.com/jJPVCbN

here is the nzb if interested. https://nzbcache.info/nzb/5e8ca8645a032 ... 746.nzb.gz

i made a thread similar a while ago https://forums.sabnzbd.org/viewtopic.ph ... 939#p99939 but not sure if this is same issue or not.

ps thanks for all the work on v1.

[safihre]

@shypike / @mastyman I have seen this before couple of times:
SABnzbd gets really confused in cases like these where each file is in the NZB twice. As you can see after adding the NZB, this NZB and other that were send with the same error have each partX twice.
So SAB dowloads them both, names them partX.rar and partX.rar.1.
Then the par2 will come and see that there are these duplicates and tries to sort of combine them, bot only for broken ones it will remove the duplicate so you're still left with some partX.rar.1 files.
So SAB, good boy, tries to extract every rar-set it can find.. Which of course fails for the rar.1 set..

No idea what to do about this.. Sometimes these double files might contain extra blocks..

[safihre]

Interesting, I see now that NZBGet for example will do this:
File "marvels.avengers-ultron.revolution.s03e02.720p.hdtv.x264-w4f.vol31+03.par2" appears twice in collection, adding only the biggest file

Sounds like a reasonable solution? We can also do that when adding the NZB, right?

[mastyman]

sounds like a good solution