[0.8.0Alpha1] SpeedLimit Change and minor Bug

[AciDCooL]

Heya,

I've been real busy last 2 years swamped with work, and haven't been release testing like I should have. Apparently that thread is completely abandoned, I allmost thought there weren't any beta's available anymore.
Anyway I haven't seen it in the release notes (correct me if i'm wrong) but the download limiter is now changed to percentage wise. In the general section of the webif or in the config u can set a maximum amount for your linespeed, thought it took my Mbit's but its MByte. Honest mistake on my part (it's now on bandwidth_max = 800kb). After that I started to tinker with my old schedules. I live on a country side with only limited bandwidth ~8Mbit and depends if the copper isn't wet (also it's shared with 2 families). Normally I had it set too 300 kb\s during the day and "full speed" at night around 03:00ish, this late since my dad still like his Counterstrike and don't want him to ring my front door every evening\night. And the way the new speedlimiter's works only required a slight adjustment on my config, and don't mind me saying it works way better this way. I see the scripting potential for a variable line speed. But I noticed 1 bug when I still had my old ini values with 0.8.0a1. The full speed at night would have been a value of 0. Instead of 0 (which would mean ignore speedlimit) 0.8.0a1 instead does 0 = 1% speed, in my humble opinion I would expect 0 to be no speed at all. I admire all the hard work and this minor issue probably has a reason to exist since the entire way the speedlimit works has changed, and to avoid exceptions this little bugger probably came into existence. No offense i'm just bringing it to your attention. And since 0.8.0a1 already upgrades the ini, maybe it's an idea to update existing limit's to match previous speed's, maybe it's impossible since there is no way to determine 100% linespeed for a person(before SAB is initialized and downloading atleast once).

For those who might interest my schedules pre 0.8.0a1:

Code: Select all

schedlines = "59 23 12347 resume ", "0 3 56 resume ", 59 23 1234567 speedlimit 0, 0 7 1234567 speedlimit 300

And working for me on 0.8.0a1(which brings it to ~320KB\s):

Code: Select all

schedlines = "59 23 12347 resume ", "0 3 56 resume ", 59 23 1234567 speedlimit 100, 0 7 1234567 speedlimit 40

I could set it to 37,5% to match my old config but 40% is easier to remember I suppose.


Thanks for all the hard work that goes into the project one commit at a time

Greets,
AciD

[shypike]

I hadn't really given compatibility with current speed schedules any thought.
You are right that 0 used to mean "no limit", but now it means effectively a pause.
For compatibility sake, 0 should still mean "no limit", but that is way to counter-intuitive for new users.
There's no easy way out, except for some one-time conversion.
I'll think about it.
Thanks for the update!

BTW: 0% --> 1% is a bug, it should just be 0.

[shypike]

I've done some testing and code inspection.
While a bit awkward maybe, in the current implementation, 0 will remove the speedlimit altogether.
It does not result in a 1% speed, but 100%.
For compatibility, I will leave it as is.
If you need 0 speed, you should program a pause.

However, there is a bug in the current implementation where "speedlimit = 0"
isn't properly evaluated at startup and when the schedules change.
In these situations, a removal of the speedlimit is ignored, leaving the effect
of the last limit set.

[AciDCooL]

Just for quick response i'm still experiencing this, here my screenshots from 40% to 0%. Gonna update to Alpha2 this weekend see if it makes any difference. If not ill post my config. Or maybe my entire folder, what ever the preference.
And don't mind the skin it's the normal one, it's just that my chrome colors are inverted.

40%
http://i.imgur.com/YHzhyBo.png

0%:
http://i.imgur.com/kj15awQ.png